[jira] [Resolved] (HBASE-18390) Sleep too long when finding region location failed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Resolved] (HBASE-18390) Sleep too long when finding region location failed

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/HBASE-18390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-18390.
-------------------------------
    Resolution: Fixed

I tried reverted to this commit

{quote}
commit 4bd5f03d22be5f8ce09c1c67cfe5d1dcc603446a
Author: Chia-Ping Tsai <[hidden email]>
Date:   Thu Jul 13 19:37:15 2017 +0800

    HBASE-18365 Eliminate the findbugs warnings for hbase-common
{quote}

The tests are still failing for me. So I do no think it is introduced by this issue.

And the actual problem is ToolProvider returns a null JavaCompiler. It seems that tools.jar is not on our classpath. If I manually add tools.jar then the tests work fine.

[~tedyu] You can open a new issue to address this.

> Sleep too long when finding region location failed
> --------------------------------------------------
>
>                 Key: HBASE-18390
>                 URL: https://issues.apache.org/jira/browse/HBASE-18390
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.3.1, 1.2.6, 1.1.11, 2.0.0-alpha-1
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>             Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
>         Attachments: HBASE-18390.v01.patch, HBASE-18390.v02.patch, HBASE-18390.v03.patch
>
>
> If RegionServerCallable#prepare failed when getRegionLocation, the location in this callable object is null. And before we retry we will sleep. However, when location is null we will sleep at least 10 seconds. And the request will be failed directly if operation timeout is less than 10 seconds. I think it is no need to keep MIN_WAIT_DEAD_SERVER logic. Use backoff sleeping logic is ok for most cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...